Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies to latest and add node 14 check #215

Closed
wants to merge 4 commits into from
Closed

chore: upgrade dependencies to latest and add node 14 check #215

wants to merge 4 commits into from

Conversation

bryantbiggs
Copy link

@bryantbiggs bryantbiggs commented Nov 18, 2020

  • update dependencies to latest versions
  • add node 14 into test matrix
  • run eslint --fix src/ due to upgrade in eslint

Supersedes #160 and #183, closes #118 and #177

This change resolves all found vulnerabilities:

784 vulnerabilities found - Packages audited: 838
Severity: 766 Low | 11 Moderate | 6 High | 1 Critical

image

@bryantbiggs bryantbiggs changed the title chore: update development dependencies chore: upgrade dependencies to latest and add node 14 check Nov 18, 2020
@bryantbiggs bryantbiggs marked this pull request as ready for review November 18, 2020 23:41
@swiftone
Copy link
Contributor

@bryantbiggs - Thanks for the PR, we'll take a look.

@swiftone
Copy link
Contributor

Internal ref: OKTA-347876

@swiftone
Copy link
Contributor

See also linting changes in https://github.com/okta/okta-sdk-nodejs/pull/212/files

@swiftone
Copy link
Contributor

@bryantbiggs - Thanks much for the PR!

Due to some internal scheduling with the U.S. holidays, this PR may not get merged until after next week, but we wanted to make sure to acknowledge the contribution and highlight this for anyone looking to address these issues in a local copy before we are able to release them.

@bryantbiggs
Copy link
Author

no worries, let me know if I can help in any way @swiftone

@denysoblohin-okta
Copy link
Contributor

denysoblohin-okta commented Dec 9, 2020

@bryantbiggs Thanks for your PR. Due to problems with tests (error "Private Key not provided") I've copied your PR with some changes: #217
Changes:

  • Removed migration from npm to yarn (in favour of Add bacon scripts #212 )
  • Less eslint fixes (using -c src/.eslintrc src/)
  • Fixed date comparisons in tests due to upgrade of chai

@denysoblohin-okta
Copy link
Contributor

Closing in favor of merged #217

@bryantbiggs bryantbiggs deleted the chore/dev-dep-updates branch December 10, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants